Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: options refactoring #147

Merged
merged 11 commits into from
Sep 15, 2023
Merged

chore: options refactoring #147

merged 11 commits into from
Sep 15, 2023

Conversation

imor
Copy link
Contributor

@imor imor commented Sep 13, 2023 •
edited
Loading

What kind of change does this PR introduce?

Refactoring

What is the current behavior?

Functions in utils related to options do not return a Result.

What is the new behavior?

  • Options related functions are moved to their own module name options.
  • These functions return a Result wherever appropriate.
  • Any code calling these functions has been updated.
  • Introduced a report_unwrap method through a trait to avoid the repetitive code snippet map_err(|e| e.into()).report().

@imor imor marked this pull request as ready for review September 14, 2023 05:48
@imor imor changed the title Fix/options refactor Options refactoring Sep 14, 2023
@imor imor requested review from burmecia and olirice September 14, 2023 13:25
@imor imor merged commit 07db254 into main Sep 15, 2023
4 checks passed
@imor imor deleted the fix/options-refactor branch September 15, 2023 04:30
@imor imor changed the title Options refactoring chore: options refactoring Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olirice olirice olirice approved these changes

@burmecia burmecia Awaiting requested review from burmecia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imor @olirice