add unit tests for Note.oct and String.asNote #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspiers
changed the title
added 2 commits
October 21, 2017 20:38
This should serve as a starting point for other unit tests.
These tests currently fail due to String.getOctave not respecting accidentals (see supercollider-quarks#11).
|
If you don't mind I'd like to wait with this one, as I guess it requires the UnitTest quark in older versions of SC. I don't suppose there are ways to do this without dependency on the UnitTest class, right? |
|
I can't think of any way which makes sense, unfortunately 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose that we consider adding unit tests for wslib. This would help eliminate uncertainty around correct behaviour, like the case described in #11.
This pull request demonstrates an example of how to do this, which could serve as a starting point for other unit tests.
Note: The tests added here for Note.oct fail, serving as a test case for #11.