Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New plugin: BFold (was: Timbre) (wavefolder) #238

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

georgezachos
Copy link

Virtual analog model of the "timbre" wavefolding circuit from the Buchla 259 Complex Waveform Generator.

@nhthn
Copy link

nhthn commented Dec 16, 2018

nice work! i'll give this a closer look later. i'm wondering if this could have a more specific name, like BFold or B259Fold?

@georgezachos
Copy link
Author

thanks! yes, either of those names are better actually, less generic. BFold might be fine, I'm not aware of other buchla popular wavefolders.

Copy link
Contributor

@patrickdupuis patrickdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new UGen!

source/VAfxUGens/sc/HelpSource/Classes/BFold.schelp Outdated Show resolved Hide resolved
@georgezachos
Copy link
Author

One last fix with the 388a903. Sorry for the sloppiness, will be more careful when I PR again.

@mossheim mossheim changed the title New plugin: Timbre (wavefolder) New plugin: BFold (was: Timbre) (wavefolder) Jan 6, 2019
Copy link

@nhthn nhthn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, sorry about the super-late reply, but this should go into master, not 3.10. 3.10 is in maintenance mode and it's only accepting bug fixes atm. PRs merged into master will be included in the upcoming 3.11 release, which is about a month or two ahead.

@mossheim
Copy link
Contributor

mossheim commented Jun 4, 2019

@georgezachos Can you please update this PR per @snappizz 's request? Thanks!

@georgezachos georgezachos changed the base branch from 3.10 to master November 23, 2019 09:50
@georgezachos
Copy link
Author

Sorry for the delay @brianlheim and thanks for the patience! I updated the PR now.

@dyfer
Copy link
Member

dyfer commented Jul 27, 2021

@yorgoszachos sorry this hasn't been attended to. Could you please rebase (again...) on to the current main?
@patrickdupuis do you think this PR is good to go, aside from the rebase?

@capital-G
Copy link
Contributor

Hey @georgezachos - would still be very cool to get these in here. Could you rebase against main so that we can have a CI run of this? If you need some help, hit me up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for review response
Development

Successfully merging this pull request may close these issues.

8 participants