Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content Types] Create and use async resource and service #2845

Merged
merged 8 commits into from
Mar 10, 2025

Conversation

jerome-poisson
Copy link
Contributor

This patch create Async ContentTypes resource, and an async service which ports methods from the legacy ones.

SDESK-7482

This patch create Async ContentTypes resource, and an async service
which ports methods from the legacy ones.

SDESK-7482
- remove `hateoas` references, they should not be needed with Async
  service.
- set type for `projection` in `on_delete_res_vocabularies` to avoid
  linter complaining.
- use `mongo_async` for `find_and_modify`

Also use `to_dict` instead of `model_dump`, as the right parameters are
then used.
Copy link
Contributor

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks fine. Just a few improvements and a couple bugs need looking into

@MarkLark86 MarkLark86 added this to the 3.0 milestone Mar 3, 2025
@jerome-poisson jerome-poisson merged commit 2681c75 into superdesk:async Mar 10, 2025
10 of 16 checks passed
@jerome-poisson jerome-poisson deleted the SDESK-7482 branch March 10, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants