Fix onChange on TreeSelelect #907
Conversation
| @@ -170,7 +170,7 @@ let options2 = [ | |||
| ] | |||
|
|
|||
| let fetchedArr = []; | |||
| fetch('https://nominatim.openstreetmap.org/search/berlin?format=json&addressdetails=1&limit=20').then(response => response.json()).then(data => fetchedArr = data); | |||
| fetch('https://nominatim.openstreetmap.org/search.php?q=berlin&exclude_place_ids=134060781&format=jsonv2').then(response => response.json()).then(data => fetchedArr = data); | |||
There was a problem hiding this comment.
inline the values so we don't have to rely on an external API
| /* | ||
| * This variable is used to distinguish changes coming from outside (from props.value) | ||
| * from those made by the user through interaction with the component. | ||
| */ |
There was a problem hiding this comment.
Include in the comment is that the purpose is to prevent triggering onChange when props change.
| @@ -169,8 +169,24 @@ let options2 = [ | |||
| }, | |||
| ] | |||
|
|
|||
| let fetchedArr = []; | |||
| fetch('https://nominatim.openstreetmap.org/search/berlin?format=json&addressdetails=1&limit=20').then(response => response.json()).then(data => fetchedArr = data); | |||
| let fetchedArr = [ | |||
There was a problem hiding this comment.
since there's only item there, what's the point to have it at all? What about removing it completelly and simply using one of demo arrays we already have?
There was a problem hiding this comment.
initial point was to present real async mode...
There was a problem hiding this comment.
async demo is using a timeout to simulate a request delay and fetchedArr was being accessed synchronously. It makes no difference which data source is being used if they are both accessed synchronously
No description provided.