Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smokescreen example url in smokescreen.html.erb #1075

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

irreal
Copy link
Contributor

@irreal irreal commented Sep 28, 2023

Summary of changes

Update incorrect url to example repo for using Smokescreen

Related GitHub and Fly.io community links

n/a

Notes

n/a

@andie787
Copy link
Contributor

thanks!

@andie787 andie787 merged commit ac59dd4 into superfly:main Sep 28, 2023
1 check passed
@irreal
Copy link
Contributor Author

irreal commented Sep 28, 2023

Hi @andie787 , I'm not sure who maintains the actual Smokescreen example that I fixed the url to.
It was out of date and not working according to the Http Proxy spec. So I fixed it in two separate PRs: fly-apps/smokescreen#2 and fly-apps/smokescreen#3

It might be useful to get those merged in, and then you could even remove the outdated tag from this document, as I now brought the example up to date and verified everything is indeed working great. I'm using it in production right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants