Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad link in SSO docs #1733

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Bad link in SSO docs #1733

merged 1 commit into from
Jul 31, 2024

Conversation

btoews
Copy link
Member

@btoews btoews commented Jul 31, 2024

Summary of changes

For installing the Fly.io GitHub App, we link to https://github.com/apps/fly-io/installations/select_target. We actually need to set a state query parameter on this request. We have an endpoint at https://fly.io/app/auth/github_app that adds the parameter and redirects to the GitHub URL.

Preview

Related Fly.io community and GitHub links

Notes

@btoews btoews merged commit 1fbc7f0 into main Jul 31, 2024
2 checks passed
@btoews btoews deleted the sso-fix branch July 31, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant