Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run slow tests in parallel #3883

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: run slow deploy tests in parallel
kzys committed Aug 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit ff5cd1211a112081384d2d0ede7b279610705ae7
16 changes: 14 additions & 2 deletions test/preflight/apps_v2_integration_test.go
Original file line number Diff line number Diff line change
@@ -415,7 +415,19 @@ func TestLaunchDetach(t *testing.T) {
require.Contains(f, res.StdOutString(), "success")
}

func TestDeployDetach(t *testing.T) {
func WithParallel(f func(*testing.T)) func(*testing.T) {
return func(t *testing.T) {
t.Parallel()
f(t)
}
}

func TestDeploy(t *testing.T) {
t.Run("Detach", WithParallel(testDeployDetach))
t.Run("DetachBatching", WithParallel(testDeployDetachBatching))
}

func testDeployDetach(t *testing.T) {
f := testlib.NewTestEnvFromEnv(t)
appName := f.CreateRandomAppName()

@@ -428,7 +440,7 @@ func TestDeployDetach(t *testing.T) {
require.Contains(f, res.StdOutString(), "started")
}

func TestDeployDetachBatching(t *testing.T) {
func testDeployDetachBatching(t *testing.T) {
f := testlib.NewTestEnvFromEnv(t)
appName := f.CreateRandomAppName()