refactor: remove flyctl/retry #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
commented
Dec 19, 2024
go.mod
Outdated
| @@ -22,6 +22,7 @@ require ( | |||
| github.com/buildpacks/pack v0.36.1 | |||
| github.com/cavaliergopher/grab/v3 v3.0.1 | |||
| github.com/cenkalti/backoff v2.2.1+incompatible | |||
There was a problem hiding this comment.
I'd like to remove cenkalti/backoff (v1) eventually, but not in this PR.
There was a problem hiding this comment.
No. It isn't that hard. I did that in this PR :)
testRetryBackoffContextTimeout has been flaky. Instead of fixing, this change removes our own retry package. We don't have to write our own. Fixes #4124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testRetryBackoffContextTimeout has been flaky.
Instead of fixing, this change removes our own retry package. We don't have to write our own.
Fixes #4124
Change Summary
What and Why:
How:
Related to:
Documentation