This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Revert deprecation warning fix, Fixes #8 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecation warning says:
File "RuleScanner.ml", line 27, characters 14-26:
27 | Some (Scanf.fscanf in_channel "%[^\r\n]\n" (fun x -> x))
^^^^^^^^^^^^
Alert deprecated: Stdlib.Scanf.fscanf
Use Scanning.from_channel then Scanf.bscanf.
But clearly I'm missing the difference between what they suggest and
what I tried
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation warning says:
But clearly I'm missing the difference between what they suggest and what I
tried. Reverting this fixes it, at the expense of reintroducing the compile
warning.