-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support prompt caching and apply Anthropic's long-context prompt format #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undo76
force-pushed
the
feat/ms-document-ids
branch
from
November 25, 2024 20:53
65b8927
to
535172d
Compare
lsorber
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It's a fairly big one so I have some more comments than the previous one 😅.
lsorber
force-pushed
the
feat/ms-document-ids
branch
from
December 3, 2024 11:14
a27ab99
to
bbde96f
Compare
undo76
commented
Dec 3, 2024
undo76
commented
Dec 3, 2024
undo76
commented
Dec 3, 2024
undo76
commented
Dec 3, 2024
undo76
commented
Dec 3, 2024
lsorber
force-pushed
the
feat/ms-document-ids
branch
from
December 3, 2024 11:54
42e4b51
to
60a7292
Compare
undo76
commented
Dec 3, 2024
undo76
commented
Dec 3, 2024
undo76
commented
Dec 3, 2024
undo76
commented
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, I think it is a big improvement. Thanks!
lsorber
changed the title
feat: Add document id and chunk ids to segments fixing order.
feat: support prompt caching and apply Anthropic's long-context prompt format
Dec 3, 2024
lsorber
approved these changes
Dec 3, 2024
This was referenced Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several improvements: