Fix JSON schema and validation (#24)

* test: invalid json * test: remove invalid json * fix: schema URI * fix: update json schema version * fix: replace property_comment with comment * fix: try keywording comment * test: invalid json * fix: remove invalid json file
superlinked · Dec 13, 2023 · fe790ed · fe790ed
1 parent aa638be
commit fe790ed
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/json-validate.yml b/.github/workflows/json-validate.yml
@@ -19,3 +19,4 @@ jobs:
         with:
           base_dir: docs/tools/vdb_table/data
           json_schema: docs/tools/vdb_table/data/vendor.schema.json
+          json_schema_version: "draft-2020-12"
diff --git a/docs/tools/vdb_table/data/vendor.schema.json b/docs/tools/vdb_table/data/vendor.schema.json
@@ -1,5 +1,5 @@
 {
-  "$schema": "https://json-schema.org/draft/2020-12",
+  "$schema": "https://json-schema.org/draft/2020-12/schema",
   "$id": "vdb_table/schema/vendor",
   "type": "object",
 
@@ -10,14 +10,14 @@
     "logo_url": { "type": "string" },
     "point_of_contact_email": { "type": "string", "format": "email" },
 
-    "oss": { "allOf": [{"$ref": "#/$defs/feature"}], "property_comment": "Open source & free to self-host" },
-    "managed_cloud": { "allOf": [{"$ref": "#/$defs/feature"}], "property_comment": "Managed Cloud Offering" },
-    "disk_index": { "allOf": [{"$ref": "#/$defs/feature"}], "property_comment": "Disk-based Index" },
+    "oss": { "allOf": [{"$ref": "#/$defs/feature"}], "$comment": "Open source & free to self-host" },
+    "managed_cloud": { "allOf": [{"$ref": "#/$defs/feature"}], "$comment": "Managed Cloud Offering" },
+    "disk_index": { "allOf": [{"$ref": "#/$defs/feature"}], "$comment": "Disk-based Index" },
 
-    "doc_size_limit": { "allOf": [{"$ref": "#/$defs/integerWithUnits"}], "property_comment": "Metadata/Doc size limit" },
-    "vector_dimensions_max": { "allOf": [{"$ref": "#/$defs/integer"}], "property_comment": "Maximum integer of vector dimensions" },
+    "doc_size_limit": { "allOf": [{"$ref": "#/$defs/integerWithUnits"}], "$comment": "Metadata/Doc size limit" },
+    "vector_dimensions_max": { "allOf": [{"$ref": "#/$defs/integer"}], "$comment": "Maximum integer of vector dimensions" },
 
-    "license": { "allOf": [{"$ref": "#/$defs/string"}], "property_comment": "OSS license for the core product" }
+    "license": { "allOf": [{"$ref": "#/$defs/string"}], "$comment": "OSS license for the core product" }
   },
 
   "$defs": {