Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rockset details under rockset.json #151

Merged
merged 9 commits into from
Feb 2, 2024

Conversation

ankit1khare
Copy link
Contributor

Feel free to reach out to me if something is unclear :)

@ankit1khare ankit1khare requested a review from a team as a code owner January 17, 2024 23:59
@ankit1khare ankit1khare changed the title Update rockset.json Update Rockset details under rockset.json Jan 18, 2024
Copy link
Contributor

@svonava svonava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ankit1khare - thank you for your PR!

Please see my comments next to your changes.

docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@ankit1khare ankit1khare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made the requested changes

@ankit1khare ankit1khare requested a review from svonava January 18, 2024 14:18
Copy link
Contributor

@dhruv-anand-aintech dhruv-anand-aintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide a reference to docs/code/notebook example in source_url for each field where you are marking support as "full" or "partial"

docs/tools/vdb_table/data/rockset.json Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
@ankit1khare
Copy link
Contributor Author

please provide a reference to docs/code/notebook example in source_url for each field where you are marking support as "full" or "partial"

We combine ANN (vector search) with metadata filtering which is hybrid search in essence. Updated the links.

docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
"support": "",
"source_url": "",
"comment": ""
"support": "full",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to none as Hybrid Search has a specific meaning in this tab le, which is different from what you explained.

Copy link
Contributor

@dhruv-anand-aintech dhruv-anand-aintech Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ankit1khare, I'm guessing you mean to point to this section https://github.com/sofia099/search_autocomplete#step-3-create-3-query-lambdas in the new repo you've linked. It seems to combine a set of exact matches with approximate lexical matches.

Hybrid Search in this table refers to "ability to merge between ranked lists of keyword search and vector search results within the DB".

Is it possible to do something like Reciprocal Rank Fusion or take a linear combination of scores from vector search and keyword search in a similar way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dhruv-anand-aintech, after all it's SQL we are talking about where we have built our own engine from scratch such that all standard SQL operations can be done on different data modalities. One can build their own weighting mechanism using SQL and get all of the analytical capabilities built into the query language (like linear combination, reciprocal rank fusion, etc.).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. It'll still be good to have an example notebook that does these types of fusion in Rockset, so that users are easily able to migrate to it from other DBs that do it under the hood.

docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Show resolved Hide resolved
Copy link
Contributor Author

@ankit1khare ankit1khare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@dhruv-anand-aintech dhruv-anand-aintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes. Thanks

docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Show resolved Hide resolved
docs/tools/vdb_table/data/rockset.json Outdated Show resolved Hide resolved
Comment on lines 71 to 77
"support": "full",
"source_url": "https://docs.rockset.com/documentation/reference/user-defined-functions",
"comment": ""
},
"embeddings_image": {
"support": "",
"source_url": "",
"support": "full",
"source_url": "https://docs.rockset.com/documentation/reference/user-defined-functions",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ability to run user-defined functions counts as "partial" support for these 2 columns. Full support would be for ready to use embedding modules (see examples in the table).

Screenshot 2024-02-02 at 1 25 03 PM

I'll switch these and merge the PR. You can comment here if there is further clarification.

@dhruv-anand-aintech dhruv-anand-aintech merged commit 1640d43 into superlinked:main Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants