Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writeup for vision-research #17

Merged
merged 21 commits into from
Feb 13, 2024
Merged

Writeup for vision-research #17

merged 21 commits into from
Feb 13, 2024

Conversation

hkristof03
Copy link
Contributor

Describe your changes

Added a writeup related to this project.

Checklist before requesting a review

  • I have followed the contribution guidelines
  • Cover image created, or given instructions about what the cover image should include and tagged maintainer to create one
  • All instructions and comments are in the comment format. Everything else will be published on the frontend

Copy link
Contributor

@morkapronczay morkapronczay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to ask for some emphasis changes in the conclusion and a small addition to the open questions but other than that great work!

@svonava svonava added the stage: content review PR under review of the high level content direction label Dec 13, 2023
@morkapronczay morkapronczay self-assigned this Dec 19, 2023
@morkapronczay morkapronczay added stage: style review PR under review for style guide compliance ( https://hub.superlinked.com/contributing ) and removed stage: content review PR under review of the high level content direction labels Jan 29, 2024
@robertdhayanturner
Copy link
Collaborator

robertdhayanturner commented Feb 2, 2024

@morkapronczay
line 25 - There is no "reference image from the COCO dataset": assets/use_cases/retrieval_from_image_and_text/reference_image.png
Were you going to upload one?

@hkristof03
Copy link
Contributor Author

@morkapronczay line 25 - There is no "reference image from the COCO dataset": assets/use_cases/retrieval_from_image_and_text/reference_image.png Were you going to upload one?

@robertdhayanturner I accidentally removed the image in the last commit (if you check the commit history). I honestly don't like the subjective changes that you made in my write up, so I will not pull those and I will just add the image here.

reference_image

robertdhayanturner and others added 9 commits February 4, 2024 13:46
updating for questions to Mór
editing still in progress
final commit, pending question re lines 130-133 being put into a table..
final... waiting for Mor's handoff to Kristof for review
just awaiting an update from Mór on all scenarios images...
change Mor's role to "contributor"
final commit on this PR
@robertdhayanturner robertdhayanturner merged commit 0f657cc into superlinked:main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage: style review PR under review for style guide compliance ( https://hub.superlinked.com/contributing )
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants