Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON schema and validation #24

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Fix JSON schema and validation #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
71752e6
test: invalid json
mamayer19 Dec 12, 2023
d5334b9
test: remove invalid json
mamayer19 Dec 12, 2023
f61a079
fix: schema URI
mamayer19 Dec 12, 2023
af029dc
fix: update json schema version
mamayer19 Dec 12, 2023
4d3a420
fix: replace property_comment with comment
mamayer19 Dec 12, 2023
10a5561
fix: try keywording comment
mamayer19 Dec 12, 2023
e40d69a
test: invalid json
mamayer19 Dec 12, 2023
4f53fa8
fix: remove invalid json file
mamayer19 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/json-validate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ jobs:
with:
base_dir: docs/tools/vdb_table/data
json_schema: docs/tools/vdb_table/data/vendor.schema.json
json_schema_version: "draft-2020-12"
14 changes: 7 additions & 7 deletions docs/tools/vdb_table/data/vendor.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://json-schema.org/draft/2020-12",
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$id": "vdb_table/schema/vendor",
"type": "object",

Expand All @@ -10,14 +10,14 @@
"logo_url": { "type": "string" },
"point_of_contact_email": { "type": "string", "format": "email" },

"oss": { "allOf": [{"$ref": "#/$defs/feature"}], "property_comment": "Open source & free to self-host" },
"managed_cloud": { "allOf": [{"$ref": "#/$defs/feature"}], "property_comment": "Managed Cloud Offering" },
"disk_index": { "allOf": [{"$ref": "#/$defs/feature"}], "property_comment": "Disk-based Index" },
"oss": { "allOf": [{"$ref": "#/$defs/feature"}], "$comment": "Open source & free to self-host" },
"managed_cloud": { "allOf": [{"$ref": "#/$defs/feature"}], "$comment": "Managed Cloud Offering" },
"disk_index": { "allOf": [{"$ref": "#/$defs/feature"}], "$comment": "Disk-based Index" },

"doc_size_limit": { "allOf": [{"$ref": "#/$defs/integerWithUnits"}], "property_comment": "Metadata/Doc size limit" },
"vector_dimensions_max": { "allOf": [{"$ref": "#/$defs/integer"}], "property_comment": "Maximum integer of vector dimensions" },
"doc_size_limit": { "allOf": [{"$ref": "#/$defs/integerWithUnits"}], "$comment": "Metadata/Doc size limit" },
"vector_dimensions_max": { "allOf": [{"$ref": "#/$defs/integer"}], "$comment": "Maximum integer of vector dimensions" },

"license": { "allOf": [{"$ref": "#/$defs/string"}], "property_comment": "OSS license for the core product" }
"license": { "allOf": [{"$ref": "#/$defs/string"}], "$comment": "OSS license for the core product" }
},

"$defs": {
Expand Down
Loading