-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ApertureDB information #532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vishakha041 - I reference a schema file in multiple comments, I should have flagged it to you from the get go - I tried to highlight when you deviate in your understanding of the fields + added thoughts on how to fix.
Hope that's useful!
I have hopefully interpreted the intentions around various fields correctly this time and addressed your comments as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions - otherwise LGTM!
@svonava please merge when you think it's good to go.
Co-authored-by: Prashanth Rao <[email protected]>
Co-authored-by: Prashanth Rao <[email protected]>
Thanks @svonava |
No description provided.