Add iOS tap in empty space to show toolbar, Android long-press in empty space to show toolbar. (Resolves #1472) #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty space to show toolbar. (Resolves #1472)
angelosilvestre
approved these changes
Oct 3, 2023
| final didTapOnExistingSelection = exactTapTextPosition != null && | ||
| _selectionBeforeTap != null && | ||
| (_selectionBeforeTap!.isCollapsed | ||
| ? exactTapTextPosition == _selectionBeforeTap!.extent |
There was a problem hiding this comment.
Should we compare just the offset to consider selections with different affinities equal?
| // Toggle the toolbar display when the user taps on the collapsed caret, | ||
| // or on top of an existing selection. | ||
| final didCaretStayInSamePlace = _selectionBeforeTap != null && | ||
| _selectionBeforeTap == widget.textController.selection && |
There was a problem hiding this comment.
Same question here about selection affinity.
matthew-carroll
deleted the
1472_supertextfield-show-toolbar-when-empty
branch
raulmabe-labhouse
added a commit
to LabhouseMobile/super_editor
that referenced
this pull request
Oct 10, 2023
…ty space to show toolbar. (Resolves superlistapp#1472) (superlistapp#1476)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add iOS tap in empty space to show toolbar, Android long-press in empty space to show toolbar. (Resolves #1472)