Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created a SuperTextFieldContext with a BuildContext and a TextFieldScroller - passed it key handlers (Resolves #1487) #1507

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Created a SuperTextFieldContext with a BuildContext and a TextFieldScroller - passed it key handlers (Resolves #1487) #1507

merged 2 commits into from
Oct 14, 2023

Conversation

matthew-carroll
Copy link
Contributor

Created a SuperTextFieldContext with a BuildContext and a TextFieldScroller - passed it key handlers (Resolves #1487)

@matthew-carroll
Copy link
Contributor Author

@rutvik110 - please let me know if this API would work for your key handlers that scroll text fields

@rutvik110
Copy link
Collaborator

rutvik110 commented Oct 14, 2023 •
edited
Loading

This looks really great! I'll give it a try with SuperDesktopTextField scroll handlers today.

@rutvik110
Copy link
Collaborator

rutvik110 commented Oct 14, 2023 •
edited
Loading

Just tried this updates on the SuperDesktopTextField scroll key handlers, works nicely!

Beside this, I identified an issue when we are setting TextInputSource to ime for textfields, an extra line is being added into the textfield on enter. This behaviour is seen across both SuperTextField and SuperDesktopField.

Desktop Demo:

Screen.Recording.2023-10-14.at.1.13.11.PM.mov

@angelosilvestre
Copy link
Collaborator

@rutvik110 We have an ongoing PR to fix that issue: #1469

angelosilvestre
angelosilvestre approved these changes Oct 14, 2023
View reviewed changes
Copy link
Collaborator

@angelosilvestre angelosilvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a single comment.

super_editor/lib/src/super_textfield/desktop/desktop_textfield.dart Show resolved Hide resolved
@matthew-carroll matthew-carroll merged commit 531b47e into main Oct 14, 2023
10 of 11 checks passed
@matthew-carroll matthew-carroll deleted the 1487_super-text-field_scroller branch October 14, 2023 18:41
matthew-carroll added a commit that referenced this pull request Oct 14, 2023
@matthew-carroll
Created a SuperTextFieldContext with a BuildContext and a TextFieldSc…
081fcbb 
…roller - passed it key handlers (Resolves #1487) (#1507)
@matthew-carroll matthew-carroll mentioned this pull request Oct 14, 2023
Merged
matthew-carroll added a commit that referenced this pull request Oct 14, 2023
@matthew-carroll
Created a SuperTextFieldContext with a BuildContext and a TextFieldSc…
462724b 
…roller - passed it key handlers (Resolves #1487) (#1507)
@rutvik110 rutvik110 mentioned this pull request Oct 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelosilvestre angelosilvestre angelosilvestre approved these changes

@rutvik110 rutvik110 Awaiting requested review from rutvik110

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SuperTextField] Introduce a scrolling api
3 participants
@matthew-carroll @rutvik110 @angelosilvestre