Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperEditor] Bumped http lower bound to v1.0.0 (Resolves #1464) #1511

Closed
wants to merge 1 commit into from
Closed

[SuperEditor] Bumped http lower bound to v1.0.0 (Resolves #1464) #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions super_editor/example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ dependencies:

charcode: ^1.1.3
flutter_keyboard_visibility: ^5.0.3
google_fonts: ^2.0.0
http: ^0.13.1
google_fonts: ^6.0.0
http: ^1.0.0
linkify: ^5.0.0
logging: ^1.0.1
uuid: ^3.0.3
Expand Down
2 changes: 1 addition & 1 deletion super_editor/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ dependencies:
characters: ^1.2.0
collection: ^1.15.0
follow_the_leader: ^0.0.4+3
http: ">=0.13.1 <2.0.0"
http: ">=1.0.0 <2.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tightening the constraint, not loosening it. Does this actually solve the problem? If users need http v1.0.0, why doesn't the existing constraints allow for that? isn't v1.0.0 >= v0.13.1 and < v2.0.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's correct, it does tightens the constraints.

On the reported issue, I was able to reproduce it within super editor example when referring the super_editor through pub.dev but wasn't able to identify why the loose constraints didn't satisfy the dependencies.
Referring the super_editor package that was present locally didn't seemed to introduced this issue when resolving deps which is unclear to me why.

This bump may be a wrong decision on my side but I'll have to give it another look to get proper answer to this and ensure if this would resolve the issue or if it's something the users could fix on their end itself.

linkify: ^5.0.0
logging: ^1.0.1
super_text_layout: ^0.1.7
Expand Down
Loading