Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Caret not blinking on iOS after dragging to scroll (Resolves #1549) #1557

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

matthew-carroll
Copy link
Contributor

Fix: Caret not blinking on iOS after dragging to scroll (Resolves #1549)

The root cause was that we were disabling blinking on touch down, and on pan start, but we weren't re-enabling blinking on pan end in the case that the user was scrolling.

There wasn't any great way to add tests for this fix because we purposefully prevent caret blinking during tests so that pumpAndSettle() doesn't throw an exception.

@matthew-carroll
Copy link
Contributor Author

CC @Jethro87

@matthew-carroll matthew-carroll merged commit 2e02167 into main Oct 24, 2023
10 of 11 checks passed
@matthew-carroll matthew-carroll deleted the 1549_caret-not-blinking-on-ios-after-scroll branch October 24, 2023 21:16
Copy link
Collaborator

@angelosilvestre angelosilvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SuperEditor] iOS carat stops blinking on scroll
2 participants