Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SuperText] - Add support for inline widgets (Resolves #2441) #2448

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

matthew-carroll
Copy link
Contributor

[SuperText] - Add support for inline widgets (Resolves #2441)

Changes:

  • Expand all selection boxes to "max" so that the selection rectangle for inline widgets isn't reduced to the height of the inline widget.
  • Position the caret forcing a downstream position to reduce buggyness from Flutter. Flutter is really broken with caret positioning near inline widgets. But "upstream" is more broken than "downstream".
  • Added a couple likely useful inline image placeholders.

@matthew-carroll
Copy link
Contributor Author

I'm gonna merge this in so I can put up a PR for SuperEditor integration. Please leave comments on anything in here that seems wrong.

@matthew-carroll matthew-carroll merged commit 53996cd into main Dec 10, 2024
13 of 14 checks passed
@matthew-carroll matthew-carroll deleted the 2441_render-inline-widgets branch December 10, 2024 05:52
Copy link
Collaborator

@angelosilvestre angelosilvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

testGoldensOnAndroid("vertical alignments", (tester) async {
await tester.pumpWidget(
_buildScaffold(
// ignore: prefer_const_constructors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to ignore prefer_const_constructors here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be a holdover from a copy/paste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SuperText] - Render inline widgets
2 participants