[SuperKeyboard] - Created a keyboard plugin #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angelosilvestre I'm gonna merge this so that I can create an initial release and use it in super_editor. Please feel free to leave comments that we can handle in followup. |
matthew-carroll
added a commit
that referenced
this pull request
Dec 22, 2024
matthew-carroll
added a commit
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperKeyboard] - Created a keyboard plugin.
The plugin reports four keyboard states on Android and iOS: closed, opening, open, closing.
The Android implementation also reports the keyboard height.
This plugin was created to provide more dependable knowledge about keyboard state for Super Editor's chat scaffold.
This PR moves Super Editor's test keyboard simulator into the new keyboard package. A followup PR will remove it from super_editor.