chore(lint): import golangci.yaml from GoToSocial and fix violations #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
changed the title
milas
commented
Jan 29, 2024
milas
commented
Jan 29, 2024
Notable changes here: * Small API breakage with `Verifier::KeyId()` -> `VerifierKeyID()` and `IsSupportedHttpSigAlgorithm()` -> `IsSupportedAlgorithm()` * License is kept as BSD-3-Clause but with GoToSocial Authors added * Exception made on `var-naming` rule for a bunch of constants that are otherwise unreadable without `_` to separate things like a constant for the value `sha512-256` Signed-off-by: Milas Bowman <[email protected]>
daenney
reviewed
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes here:
Verifier::KeyId()->Verifier::KeyID()BSD-3-Clausebut withGoToSocial Authorsadded (cc @NyaaaWhatsUpDoc @daenney)var-namingrule for a bunch of constants that are otherwise unreadable without_to separate things like a constant for the valuesha512-256(e.g.sha512256instead ofsha512_256😛)