fix: changes for multitenancy dashboard #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Jul 18, 2024
api_spec.yaml
Outdated
|
|
||
| - `null`: When set to `null`, the SDK will use firstFactors defined in the SDK | ||
| - `[]` (empty array): No first factors would be enabled for the tenant | ||
| - non-empty array: The first factors that are enabled for the tenant |
There was a problem hiding this comment.
These three points are very unclear.
There was a problem hiding this comment.
For example when you say "the SDK will use" - what SDK? This is just an API spec. Another example, is non-empty array: The first factors that are enabled for the tenant -> when reading it, it makes no sense.
api_spec.yaml
Outdated
|
|
||
| If first factors are not specified while creating a new connection uri domain, all the login methods will be enabled by default. | ||
|
|
||
| `requiredSecondaryFactors` can be set to null to remove all entries in the core, or a non empty string array to be updated in the core. Setting of empty array is disallowed. |
There was a problem hiding this comment.
right. But what is the effect or removing it and setting it in the core? Please be clear. And make it a bullet point like you have done for firstFactors
api_spec.yaml
Outdated
|
|
||
| - `null`: When set to `null`, the SDK will use firstFactors defined in the SDK | ||
| - `[]` (empty array): No first factors would be enabled for the tenant | ||
| - non-empty array: The first factors that are enabled for the tenant |
There was a problem hiding this comment.
What are the values that it can accept if its non empty
| @@ -5267,12 +5367,82 @@ paths: | |||
| '500': | |||
| $ref: '#/components/responses/500' | |||
|
|
|||
| /recipe/multitenancy/connectionuridomain/list/v2: | |||
There was a problem hiding this comment.
also mention the possible factors that can be in the firstFactors and requiredSecondaryFactors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.