-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #125 from supertokens/update-pr-checklist
update PR Template
- Loading branch information
Showing
1 changed file
with
35 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,47 +35,48 @@ | |
| - (Optional) Tested on physical mobile and tablet device for: | ||
| - [ ] Android | ||
| - [ ] iOS (including iPadOS) | ||
|
|
||
| ### Feature tests: | ||
|
|
||
| - [ ] Search | ||
| - [ ] Search with anything that results in an empty state in the UI (Should show an empty state explaining that there were no results) | ||
| - [ ] Search with an empty string (Dashboard should not allow this) | ||
| - [ ] Email search | ||
| - [ ] Serach for "e" with email tag and then delete the tag (Should show one user initially then show all with pagination enabled) | ||
| - [ ] Search for "test" with the email tag (Expect 14 results) | ||
| - [ ] Search with "g" for email tag (Expect 3 results) | ||
| - [ ] Search with "g" and "p" for email tag (Expect 3 results) | ||
| - [ ] Search with "g" and "t" for email tag, then delete "t" (Expect 17 results initially, then 3) | ||
| - [ ] Search with "@" for email tag (Expect 0 results (This is because at the time of adding this case we would only check for the start of the email or the domain and not any character inside the full email)) | ||
| - [ ] Search for "[email protected]" with email tag (Expect 1 result) | ||
| - [ ] Search for "[email protected]" with email tag (Expect 3 results) | ||
| - [ ] Search for "gmail" with email tag (Expect 3 results) | ||
| - [ ] Search for "ABC" with email tag (Expect 0 results) | ||
| - [ ] Search for "a" with email tag (Expect 0 results (This is because at the time of adding this we only check if the email starts with the query and not contains)) | ||
| - [ ] Search for "team" with email tag (Expect 0 results) | ||
| - [ ] Search for "782" with email tag (Expect 1 result) | ||
| - [ ] Serach for "e" with email tag and then delete the tag (Should show one user initially then show all with pagination enabled) | ||
| - [ ] Search for "test" with the email tag (Expect 14 results) | ||
| - [ ] Search with "g" for email tag (Expect 3 results) | ||
| - [ ] Search with "g" and "p" for email tag (Expect 3 results) | ||
| - [ ] Search with "g" and "t" for email tag, then delete "t" (Expect 17 results initially, then 3) | ||
| - [ ] Search with "@" for email tag (Expect 0 results (This is because at the time of adding this case we would only check for the start of the email or the domain and not any character inside the full email)) | ||
| - [ ] Search for "[email protected]" with email tag (Expect 1 result) | ||
| - [ ] Search for "[email protected]" with email tag (Expect 3 results) | ||
| - [ ] Search for "gmail" with email tag (Expect 3 results) | ||
| - [ ] Search for "ABC" with email tag (Expect 0 results) | ||
| - [ ] Search for "a" with email tag (Expect 0 results (This is because at the time of adding this we only check if the email starts with the query and not contains)) | ||
| - [ ] Search for "team" with email tag (Expect 0 results) | ||
| - [ ] Search for "782" with email tag (Expect 1 result) | ||
| - [ ] Phone search | ||
| - [ ] Search for "1" with phone tag (Expect 3 results) | ||
| - [ ] Search for "+1" with phone tag (Expect 3 results) | ||
| - [ ] Search for "91" with phone tag (Expect 1 result) | ||
| - [ ] Search for "291" with phone tag (Expect 0 results) | ||
| - [ ] Search for "+12" with phone tag (Expect 2 results) | ||
| - [ ] Search for "5" with phone tag (Expect 0 results) | ||
| - [ ] Search for "1(" with phone tag (Expect 0 results (This is because we render phone numbers with brackets so users may end up searching with that)) | ||
| - [ ] Search for "1" with phone tag (Expect 3 results) | ||
| - [ ] Search for "+1" with phone tag (Expect 3 results) | ||
| - [ ] Search for "91" with phone tag (Expect 1 result) | ||
| - [ ] Search for "291" with phone tag (Expect 0 results) | ||
| - [ ] Search for "+12" with phone tag (Expect 2 results) | ||
| - [ ] Search for "5" with phone tag (Expect 0 results) | ||
| - [ ] Search for "1(" with phone tag (Expect 0 results (This is because we render phone numbers with brackets so users may end up searching with that)) | ||
| - [ ] Provider search | ||
| - [ ] Search for "g" with provider tag (Expect 5 results) | ||
| - [ ] Search for "gi" with provider tag (Expect 2 results) | ||
| - [ ] Search for "t" with provider tag (Expect 0 results) | ||
| - [ ] Search for "google" with provider tag (Expect 3 results) | ||
| - [ ] Search for "g" with provider tag (Expect 5 results) | ||
| - [ ] Search for "gi" with provider tag (Expect 2 results) | ||
| - [ ] Search for "t" with provider tag (Expect 0 results) | ||
| - [ ] Search for "google" with provider tag (Expect 3 results) | ||
| - [ ] Combination testing | ||
| - [ ] Search with "g" for email tag and "g" for provider tag (Expect 1 result) | ||
| - [ ] Search for "github" with provider tag and "782" with email tag (Expect 1 result) | ||
| - [ ] Search for "github" and "google" with provider tag (Expect 5 results) | ||
| - [ ] Search for "j" and "g" with email tag (Expect 6 results) | ||
| - [ ] Search for "1" and "91" with phone tag (Expect 4 results) | ||
| - [ ] Search with "google" for provider tag and "1" for phone tag (Expect 0 results) | ||
| - [ ] Search for "g" with email tag and "1" with phone tag (Expect 0 results) | ||
| - [ ] Search for "k" with provider and "a", "g", "b" (in that order) for email (Expect 0 resutls) | ||
| - [ ] Search with "g" for email tag and "g" for provider tag (Expect 1 result) | ||
| - [ ] Search for "github" with provider tag and "782" with email tag (Expect 1 result) | ||
| - [ ] Search for "github" and "google" with provider tag (Expect 5 results) | ||
| - [ ] Search for "j" and "g" with email tag (Expect 6 results) | ||
| - [ ] Search for "1" and "91" with phone tag (Expect 4 results) | ||
| - [ ] Search with "google" for provider tag and "1" for phone tag (Expect 0 results) | ||
| - [ ] Search for "g" with email tag and "1" with phone tag (Expect 0 results) | ||
| - [ ] Search for "k" with provider and "a", "g", "b" (in that order) for email (Expect 0 resutls) | ||
| - [ ] General UI testing | ||
| - [ ] Test that emty state renders fine (no overflow, no UI glitches, responsiveness etc) | ||
| - [ ] Test that the list renders fine (no overflow, no UI glitches, responsiveness etc) | ||
|
|
@@ -86,6 +87,7 @@ | |
| - [ ] Test that search is visible if the feature is enabled | ||
| - [ ] Multi tenant testing | ||
| - [ ] Create one tenant (tenant1), and add 3 users to them. In the dashboard, when you switch to that tenant, it should list those users. | ||
| - [ ] Create a user in tenant1 and using backend sdk's(Go, Python, Node) associate the user to a different tenant and select that tenant on the dashboard from the tenants dropdown, it should show that user in the list | ||
|
|
||
| ## Documentation changes | ||
|
|
||
|
|
||