🛠 Close modal when overlay is clicked, by default

supertokens · May 24, 2024 · b3a04d0 · b3a04d0
1 parent bfa4a4b
commit b3a04d0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/ui/components/dialog/index.tsx b/src/ui/components/dialog/index.tsx
@@ -26,6 +26,7 @@ type DialogCommonProps = {
 
 type DialogProps = DialogCommonProps & {
 	title?: string;
+	/** Determines whether the dialog should be closed when user clicks on the overlay, true by default */
 	closeOnOverlayClick?: boolean;
 	isError?: boolean;
 	onCloseDialog: () => void;
@@ -41,7 +42,7 @@ function removeNoScrollFromBody() {
 }
 
 function Dialog(props: DialogProps) {
-	const { children, className = "", closeOnOverlayClick = false, onCloseDialog, title, lockScroll = true } = props;
+	const { children, className = "", closeOnOverlayClick = true, onCloseDialog, title, lockScroll = true } = props;
 
 	useEffect(() => {
 		if (!lockScroll) return;

diff --git a/src/ui/components/tenants/tenantDetail/providerListDialog/ProviderListDialog.tsx b/src/ui/components/tenants/tenantDetail/providerListDialog/ProviderListDialog.tsx
@@ -38,7 +38,6 @@ export const ProviderListDialog = ({
 	return (
 		<Dialog
 			onCloseDialog={onCloseDialog}
-			closeOnOverlayClick
 			className="provider-dialog-container">
 			<DialogContent>
 				<div>