-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Convert 'select" element to 'input' element #148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e5804e
into
feat/add-multitenancy-dashboard
1 of 3 checks passed
sattvikc
added a commit
that referenced
this pull request
Jul 15, 2024
* Add tenant management page * Fix icons * Fetch tenants on load * Add login methods for tenants * Add search input component * Integrate search component * Add tenants not found state * Update changelog * Add create new tenant flow * Change TenantManagement component to use arrow function * Handle other errors when creating tenant * Handle tenant row click * Add get tenant info API * Fetch tenant details and handle loading and error states * Add tenant detail header * Add core config section * Add initial core config section * Add toggle component * Finish core config UI * Wrap up the core config section * Add first and secondary factors section UI * Integrate adding core config * Handle property delete * Handle saving config properties * Fetch core config from the API * Integrate MFA * Integrate see users button * Make details page responsive * Add warning about MFA recipe * Handle delete tenant * Add third party section * Add third party provider listing section * 'Add third-party provider configuration UI * Add client configuration collapsible section * Improve toggle focus visuals * Update third party UI to work with custom fields * Handle crud operations for built in providers * Use core APIs for core config list * Build custom provider UI * Fix types * Refactor field inputs * Integrate custom providers section * Add prefix to third party field * Add additional scopes to the client config * Handle merging providers based on different providers in core and static * Handle no login methods state * Show relevant errors when no login methods added * Add dialog to prompt adding providers when none added yet. * Add SAML provider configuration handling * Refactor tenant API routes for core config list eg/ fetching URL change needed. Fix missing data fetch when listing tenants. * Remove the method to read initialized recipe from window * Show relevant errors directly from core when creating tenant * Use tenant id from path * Add different error states for login methods * Move search state up the tree * Update tenant detail and login methods API and fix type errors * Integrate core config section * WIP: Third party provider integration * Merge provider forms * Finish third party integration * Update third party API * Move providers list to dialog * API updates * Fixes for provider form * Ask for tenantId when deleting tenant * Add edit plugin property modal * Use name instead of id for third party providers section * Remove mocks for third party APIs * Move require email outside userInfoMap * Login methods section add API call to individual toggle * Update example and copy for core config * Update core config API * Fix styling issues and removed unused components * Revert server file * Revert error on success in login methods * fix: test cases for tenant management dashboard * Update core config UI * Fix responsiveness * Use svg for all third party provider icons * Review updates * New UI for third party id suffix * Login methods review updates and minor CSS fixes * fix: core config * fix: as per updated apis * fix: multiline input for apple private key * fix: services cleanup * fix: create tenant * fix: create tenant * fix: error messages * fix: pr comments * fix: third party id prefix * fix: pr comments * fix: pr comments * fix: error message * 💇♂️ Remove body scroll from dialog, by default * 💇♀️ Remove overflow from dashboard layout * 🛠 Close modal when overlay is clicked, by default * 💇♀️ Fix layout style * 💇♀️ Fix tenant page responsiveness * 💇♀️ Fix third-party login responsiveness * 📝 Update changelog * fix: remove msg * fix: minor fixes * fix: version update * fix: provider form * fix: name dropdown for boxy saml * fix: remove openid * fix: apple * fix: name compulsory for custom provider * fix: mfa override error * fix: Convert 'select" element to 'input' element (#148) * fix overflowing text * Use convert select element to an input-dropdown * Use 100% width for dropdown options * revert changelog changes * fix: type * fix: scope normalisation * fix: minor --------- Co-authored-by: Sattvik Chakravarthy <[email protected]> Co-authored-by: Favour Ohans <[email protected]> Co-authored-by: Sattvik Chakravarthy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Problem Statement
This PR fixes the following.
https://www.loom.com/share/d310936b9dec4b1395d41913d27b301e?sid=b48a56f8-f957-4007-84bd-adb7fc04fec1
Summary of solution
(Overview of how the problem is solved by this PR)
Related issues
Test Plan
Tested on all primary browsers for:
Feature tests:
Dashboard Admin access.
POST
,PUT
andDELETE
endpoints with admins only access enabled for the dashboard recipe.POST
,PUT
andDELETE
endpoints without the admins only access enabled.Search
General UI testing
Multi tenant testing
User Roles and Permissions testing
feature_not_enabled
state on both userDetails page and user roles page.User creation
emailpassword
andthirdpartyemailpassword
together and individually.passwordless
andthirdpartypasswordless
together and individually.contactMethod
's ensure that the frontend displays relevant UI based on thecontactMethod
selected.emailpassword
andpasswordless
user with the same email and make sure that the accounts are linked.User details
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
package.json
package-lock.json
src/version.ts
npm run build
Remaining TODOs for this PR