Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: imports #695

Closed
wants to merge 7 commits into from
Closed

test: imports #695

wants to merge 7 commits into from

Conversation

wtusfo
Copy link
Contributor

@wtusfo wtusfo commented May 17, 2023

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs

Remaining TODOs for this PR

  • Item1
  • Item2

@wtusfo wtusfo marked this pull request as draft May 17, 2023 12:22
@github-actions
Copy link

github-actions bot commented May 17, 2023

size-limit report 📦

Path Size
lib/build/index.js 9.45 KB (0%)
recipe/session/index.js 9.58 KB (0%)
recipe/thirdpartyemailpassword/index.js 17.14 KB (0%)
recipe/thirdparty/index.js 13.66 KB (0%)
recipe/emailpassword/index.js 9.23 KB (0%)
recipe/emailverification/index.js 6.84 KB (0%)
recipe/passwordless/index.js 62.51 KB (0%)
recipe/thirdpartypasswordless/index.js 70.74 KB (0%)
recipe/emailverification/prebuiltui.js 19.71 KB (0%)
recipe/thirdpartyemailpassword/prebuiltui.js 33.43 KB (0%)
recipe/thirdparty/prebuiltui.js 17.21 KB (0%)
recipe/emailpassword/prebuiltui.js 24.54 KB (0%)
recipe/passwordless/prebuiltui.js 98.59 KB (0%)
recipe/thirdpartypasswordless/prebuiltui.js 109.13 KB (0%)

@wtusfo wtusfo marked this pull request as ready for review May 18, 2023 08:05
@porcellus porcellus changed the title Test/imports test: imports May 19, 2023
Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a GH action check or something similar that:

  • builds these examples
  • checks that logging in works.

@wtusfo
Copy link
Contributor Author

wtusfo commented May 22, 2023

Please add a GH action check or something similar that:

  • builds these examples
  • checks that logging in works.

GH build examples before running tests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/with-phone-password

Copy link

@frankagbogun frankagbogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/with-phone-password

Copy link

@frankagbogun frankagbogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabhpoddar rishabhpoddar deleted the test/imports branch October 11, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants