feat: Add init method support, better support for dynamic route handlers and added support for exporting logic from plugins #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No documentation updates required. |
porcellus
requested changes
May 28, 2025
coolbueb
changed the base branch from
feat/plugin/experiment
to
feat/plugin/base
porcellus
requested changes
Jun 18, 2025
| @@ -297,6 +297,7 @@ export const FormBase: React.FC<FormBaseProps<any>> = (props) => { | |||
| } | |||
| } | |||
| } catch (e) { | |||
| console.error(e); | |||
There was a problem hiding this comment.
This is a debugging change left in there it looks like.
Comment on lines
+570
to
+594
| let functionLayers = [_config.override?.functions]; | ||
| for (const plugin of plugins) { | ||
| const overrides = plugin[recipeId]; | ||
| if (overrides) { | ||
| _config = { ...(overrides.config ? overrides.config(_config) : _config) }; | ||
| if (overrides.functions !== undefined) { | ||
| functionLayers.push(overrides.functions as any); | ||
| } | ||
| } | ||
| } | ||
| functionLayers = functionLayers.reverse().filter((layer) => layer !== undefined); | ||
|
|
||
| if (functionLayers.length > 0) { | ||
| _config.override = { | ||
| ..._config.override, | ||
| functions: (oI: any, builder: OverrideableBuilder<any>) => { | ||
| for (const layer of functionLayers) { | ||
| builder.override(layer as any); | ||
| } | ||
| return oI as any; | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| return _config; |
There was a problem hiding this comment.
This doesn't do anything in auth-react.
Comment on lines
+90
to
+92
| const normalisedConfig = normaliseMultiFactorAuthFeature( | ||
| applyPlugins(TOTP.RECIPE_ID, config, overrideMaps ?? []) | ||
| ); |
There was a problem hiding this comment.
We do not need to do this I think (see my other comment on applyPlugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.someFunc: function () {..}).size-limitsection ofpackage.jsonwith the size limit set to the current size rounded up.rollup.config.mjslib/ts/types.tslib/ts/recipe/multifactorauth/types.tsRemaining TODOs for this PR