Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app info refactor #389

Merged
merged 29 commits into from
Nov 25, 2023
Merged

app info refactor #389

merged 29 commits into from
Nov 25, 2023

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Nov 22, 2023

Summary of change

TODO

Related issues

Test Plan

TODO

Documentation changes

TODO

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Make sure that in debug mode, the appInfo content is printed out properly:
    • with GetOrigin function
      • With value for apiBasePath
      • Without value for apiBasePath
    • without GetOrigin function
      • With value for apiBasePath
      • Without value for apiBasePath
  • Manually check analytics API is still sending right website domain value
  • Add test for CreateResetPasswordLink and SendResetPasswordEmail for ep and tpep recipe
  • FIx example apps in golang repo
  • Docs changes

@rishabhpoddar rishabhpoddar marked this pull request as ready for review November 25, 2023 10:47
@rishabhpoddar rishabhpoddar merged commit 1f08095 into 0.17 Nov 25, 2023
4 of 6 checks passed
@rishabhpoddar rishabhpoddar deleted the appinfo-refactor branch November 25, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant