Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default to st-auth-mode if getTokenTransferMethod returns any in… #405

Conversation

furkansenharputlu
Copy link
Contributor

… createNewSession

Summary of change

CreateNewSession now defaults to the value of the st-auth-mode header (if available) if the configured GetTokenTransferMethod returns any.

Related issues

Test Plan

Added tests that check the output of createNewSession if:

  • GetTokenTransferMethod returns any
  • st-auth-mode is: cookie, header, or not set

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens/constants.go
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In supertokens/constants.go > version variable
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/config_utils.go file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If access token structure has changed
    • Modified test in session/accessTokenVersions_test.go to account for any new claims that are optional or omitted by the core

@rishabhpoddar rishabhpoddar changed the base branch from master to 0.17 April 25, 2024 06:07
@rishabhpoddar rishabhpoddar merged commit 0eff984 into supertokens:0.17 Apr 25, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants