fix: remove db password from logs #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Jan 27, 2024
src/main/java/io/supertokens/storage/mysql/config/MySQLConfig.java
Outdated
Show resolved
Hide resolved
rishabhpoddar
approved these changes
Feb 1, 2024
rishabhpoddar
suggested changes
Feb 1, 2024
src/test/java/io/supertokens/storage/mysql/test/LoggingTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/supertokens/storage/mysql/test/LoggingTest.java
Outdated
Show resolved
Hide resolved
rishabhpoddar
approved these changes
Feb 6, 2024
sattvikc
added a commit
that referenced
this pull request
Mar 11, 2024
* fix: remove db password from logs (#89) * fix: remove db password from logs * fix: mask db password * fix: Add tests * fix: Add more tests * fix: PR changes * fix: tests for connection pool (#90) * adding dev-v5.0.6 tag to this commit to ensure building * fix: cicd tests (#92) * fix: logging test (#93) * adding dev-v5.0.6 tag to this commit to ensure building * fix: flaky test (#94) * fix: make connection pool test less flaky * fix: test * fix: typo * adding dev-v5.0.6 tag to this commit to ensure building * fix: adds idle timeout and minimum idle configs (#95) * fix: idle connection configs * test: protected configs * adding dev-v5.0.6 tag to this commit to ensure building * fix: cicd (#96) * fix: cicd * fix: test * adding dev-v5.0.6 tag to this commit to ensure building * fix: typo (#97) * adding dev-v5.0.6 tag to this commit to ensure building * fixes tests * adding dev-v5.0.6 tag to this commit to ensure building * fix: Vulnerability fix (#98) * fix: updated dependencies * chore: version and changelog * fix: versions * adding dev-v5.0.7 tag to this commit to ensure building * fix: dependencies (#101) * fix: dependency fix * fix: dep fix * adding dev-v5.0.7 tag to this commit to ensure building * fix: fixes storage handling for non-auth recipes (#102) * fix: non-auth fix * fix: migration script and test fixes * fix: plugin interface version * fix: remove unnecessary func * adding dev-v6.0.0 tag to this commit to ensure building --------- Co-authored-by: Ankit Tiwari <[email protected]> Co-authored-by: rishabhpoddar <[email protected]>
rishabhpoddar
added a commit
that referenced
this pull request
Mar 13, 2024
* fix: mfa and totp updates * fix: queries * fix: misc fixes (#80) * fix: mfa * fix: queries * fix: queries * fix: mfa changes (#87) * feat: Add support to update the signing key type of a session (#88) * feat: make refresh update the signing key type of sessions * chore: update changelog * Merge 8.0 (#103) * fix: remove db password from logs (#89) * fix: remove db password from logs * fix: mask db password * fix: Add tests * fix: Add more tests * fix: PR changes * fix: tests for connection pool (#90) * adding dev-v5.0.6 tag to this commit to ensure building * fix: cicd tests (#92) * fix: logging test (#93) * adding dev-v5.0.6 tag to this commit to ensure building * fix: flaky test (#94) * fix: make connection pool test less flaky * fix: test * fix: typo * adding dev-v5.0.6 tag to this commit to ensure building * fix: adds idle timeout and minimum idle configs (#95) * fix: idle connection configs * test: protected configs * adding dev-v5.0.6 tag to this commit to ensure building * fix: cicd (#96) * fix: cicd * fix: test * adding dev-v5.0.6 tag to this commit to ensure building * fix: typo (#97) * adding dev-v5.0.6 tag to this commit to ensure building * fixes tests * adding dev-v5.0.6 tag to this commit to ensure building * fix: Vulnerability fix (#98) * fix: updated dependencies * chore: version and changelog * fix: versions * adding dev-v5.0.7 tag to this commit to ensure building * fix: dependencies (#101) * fix: dependency fix * fix: dep fix * adding dev-v5.0.7 tag to this commit to ensure building * fix: fixes storage handling for non-auth recipes (#102) * fix: non-auth fix * fix: migration script and test fixes * fix: plugin interface version * fix: remove unnecessary func * adding dev-v6.0.0 tag to this commit to ensure building --------- Co-authored-by: Ankit Tiwari <[email protected]> Co-authored-by: rishabhpoddar <[email protected]> * fix: mysql (#104) --------- Co-authored-by: Mihály Lengyel <[email protected]> Co-authored-by: Ankit Tiwari <[email protected]> Co-authored-by: rishabhpoddar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR removes the db password from being logged.
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlebuild.gradle, please make sure to add them inimplementationDependencies.json.git tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.