Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(h3framework): Added support for h3 framework #297

Closed
wants to merge 13 commits into from

Conversation

KitsuneKenshi
Copy link

@KitsuneKenshi KitsuneKenshi commented May 1, 2022

Summary of change

Added full support for h3 framework, which is used in Nuxt3.

Related issues

Test Plan

Manual testing of all functions that got added.

Documentation changes

TODO

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

Remaining TODOs for this PR

  • Create tests for new framework (only made one because I couldn't run tests on windows)

@rishabhpoddar
Copy link
Contributor

Hey @kall7 can you please make sure that all the PR checks above pass?

@KitsuneKenshi
Copy link
Author

I'll do it this weekend

CHANGELOG.md Outdated Show resolved Hide resolved
@elliotjarnit
Copy link

What is the current status on this? It seems abandoned

@rishabhpoddar rishabhpoddar changed the base branch from 9.2 to 11.0 July 11, 2022 06:45
@rishabhpoddar rishabhpoddar mentioned this pull request Jul 11, 2022
11 tasks
@rishabhpoddar
Copy link
Contributor

Closing this PR since it's abandoned. Instead, continuing it here: #351.

Thanks @kall7 for the work so far, @Swiftzerr you may want to look at the new PR and considering forking and contributing to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants