-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add edge compatibility for custom frameworks and Next.JS #918
Merged
porcellus
merged 33 commits into
supertokens:20.1
from
deepjyoti30Alt:feat/edge-compatibility-next
Sep 9, 2024
Merged
feat: Add edge compatibility for custom frameworks and Next.JS #918
porcellus
merged 33 commits into
supertokens:20.1
from
deepjyoti30Alt:feat/edge-compatibility-next
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepjyoti30Alt
changed the title
[WIP] Add edge compatibility for NextJS
Add edge compatibility for NextJS
Aug 30, 2024
❌ Deploy Preview for precious-marshmallow-968a81 failed.
|
❌ Deploy Preview for astounding-pegasus-21c111 failed.
|
porcellus
requested changes
Aug 30, 2024
porcellus
requested changes
Sep 2, 2024
porcellus
requested changes
Sep 3, 2024
deepjyoti30Alt
force-pushed
the
feat/edge-compatibility-next
branch
from
September 4, 2024 18:27
ec62f8c
to
2f2fb62
Compare
* Add init support for testing hono deployments on CF with edge * Fix the directory path in hono workflow * Fix the deploy command * Fix tests to use assert instead * Remove unused build command * Update hono edge tests to test session endpoint as well * Update README to contain proper details * Drop brotli decompression support * Remove brotli as a dependency
porcellus
requested changes
Sep 5, 2024
deepjyoti30Alt
changed the title
Add edge compatibility for NextJS
feat: Add edge compatibility without nodejs_compat flag
Sep 5, 2024
deepjyoti30Alt
changed the title
feat: Add edge compatibility without nodejs_compat flag
feat: Add edge compatibility for custom frameworks and Next.JS
Sep 5, 2024
porcellus
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR adds fixes for various things that break when running this SDK with next.js on edge runtime.
Related issues
runtime = 'edge'
#745Test Plan
Testing with NextJS app router in edge runtime:
edge
runtime by addingexport const runtime = "edge";
to the top of the file.npm run build
ornpm run dev
(live server)Testing with NextJS pages router in edge runtime
edge
runtime by addingexport const runtime = "edge";
to the top of the file.npm run build
ornpm run dev
(live server)Test with express to confirm that
inflate
works with different compression methods:br
,gzip
anddeflate
.body.json
.Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)lib/ts/version.ts
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
recipe/thirdparty/providers/configUtils.ts
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.add-ts-no-check.js
file to include thatsomeFunc: function () {..}
).exports
inpackage.json