-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove fastify with type implementation #932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for precious-marshmallow-968a81 canceled.
|
✅ Deploy Preview for astounding-pegasus-21c111 canceled.
|
Deploying supertokens-node-pr-check-for-edge-function-compat with Cloudflare Pages
|
deepjyoti30-st
force-pushed
the
feat/remove-fastify-with-type-implementation
branch
from
October 3, 2024 04:29
a9b3065
to
73353bf
Compare
porcellus
requested changes
Oct 4, 2024
porcellus
approved these changes
Oct 4, 2024
Co-authored-by: Mihály Lengyel <[email protected]>
deepjyoti30-st
force-pushed
the
feat/remove-fastify-with-type-implementation
branch
from
October 4, 2024 11:24
3c10516
to
02408ed
Compare
porcellus
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
This PR replicates fastify types that are used in the SDK to avoid type mismatches through different versions of fastify. This was as reported by an user on discord (and later on reproduced locally by using the sdk with fastify 5.x)
This also updates the fastify example to test with the newly added changes. The fastify version was bumped to 5.x and as a result some other dependencies (like typescript, formbody, cors) had to be updated.
Another thing to note is, react-scripts is a dependency of the fastify example's frontend code and it had a TS version related conflict with latest fastify requirements so I moved it to be a dependency of frontend directory and added a
preinstall
script to install this dependency whennpm i
is run.Related issues
Test Plan
Fastify example tests should pass.
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)lib/ts/version.ts
frontendDriverInterfaceSupported.json
file has been updated (if needed)package.json
package-lock.json
lib/ts/version.ts
npm run build-pretty
recipe/thirdparty/providers/configUtils.ts
file,createProvider
function.git tag
) in the formatvX.Y.Z
, and then find the latest branch (git branch --all
) whoseX.Y
is greater than the latest released tag.add-ts-no-check.js
file to include thatsomeFunc: function () {..}
).exports
inpackage.json