feat: Add cache control for jwks endpoint #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KShivendu
commented
Aug 25, 2023
supertokens_python/querier.py
Outdated
Comment on lines
262
to
272
| res: Dict[str, Any] = {"_headers": dict(response.headers)} | ||
|
|
||
| if response.headers.get("content-type").startswith("text"): | ||
| res["_text"] = response.text | ||
|
|
||
| try: | ||
| return response.json() | ||
| res.update(response.json()) | ||
| except JSONDecodeError: | ||
| return response.text | ||
| pass | ||
|
|
||
| return res |
There was a problem hiding this comment.
I tried with creating a QuerierResponse class as well but that will require too many changes throughout the codebase. Plus, we aren't actually using response.text anywhere. So made it (response.text) part of the dict response.
10 tasks
rishabhpoddar
suggested changes
Sep 22, 2023
rishabhpoddar
suggested changes
Sep 26, 2023
supertokens_python/querier.py
Outdated
Comment on lines
290
to
296
| if response.headers.get("content-type", "").startswith("text"): | ||
| res["_text"] = response.text | ||
|
|
||
| try: | ||
| return response.json() | ||
| res.update(response.json()) | ||
| except JSONDecodeError: | ||
| return response.text | ||
| pass |
There was a problem hiding this comment.
this is changing the semantics of how things were done. Please fix
| @@ -40,8 +40,9 @@ class CreateJwtResultUnsupportedAlgorithm: | |||
|
|
|||
|
|
|||
| class GetJWKSResult: | |||
| def __init__(self, keys: List[JsonWebKey]): | |||
| def __init__(self, keys: List[JsonWebKey], validity_in_secs: Optional[int]): | |||
There was a problem hiding this comment.
Suggested change
| def __init__(self, keys: List[JsonWebKey], validity_in_secs: Optional[int]): | |
| def __init__(self, keys: List[JsonWebKey], validity_in_secs: Optional[int] = None): |
|
Merged 0.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Add cache control for jwks endpoint
Related issues
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the core