Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added network interceptor hook #458

Merged
merged 10 commits into from
Nov 9, 2023

Conversation

IamMayankThakur
Copy link
Contributor

@IamMayankThakur IamMayankThakur commented Nov 7, 2023

Summary of change

  • Added NetworkInterceptor to the ConnectionInfo config.

    • This can be used to capture/modify all the HTTP requests sent to the core.
  • Fixed the dependencies in the example apps

    • Example apps will not fetch the latest version of the frameworks

Related issues

Test Plan

Added unit tests

Documentation changes

TBD

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Documentation

this hook can be used to capture all requests sent to the core
updated requirements of example apps
supertokens_python/querier.py Show resolved Hide resolved
supertokens_python/querier.py Show resolved Hide resolved
supertokens_python/querier.py Outdated Show resolved Hide resolved
supertokens_python/recipe/session/session_functions.py Outdated Show resolved Hide resolved
supertokens_python/supertokens.py Show resolved Hide resolved
tests/test_network_interceptor.py Outdated Show resolved Hide resolved
supertokens_python/asyncio/__init__.py Outdated Show resolved Hide resolved
supertokens_python/supertokens.py Show resolved Hide resolved
supertokens_python/recipe/dashboard/api/users_count_get.py Outdated Show resolved Hide resolved
supertokens_python/supertokens.py Outdated Show resolved Hide resolved
supertokens_python/syncio/__init__.py Outdated Show resolved Hide resolved
supertokens_python/supertokens.py Outdated Show resolved Hide resolved
removed default user_context value from internal functions
@rishabhpoddar rishabhpoddar merged commit 0011932 into 0.16 Nov 9, 2023
3 of 4 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/network-interceptor-hook branch November 9, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants