Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking token refresh while animations are running #107

Merged
merged 8 commits into from
Sep 13, 2023

Conversation

melvynhills
Copy link
Contributor

Summary of change

Use setImmediate to trigger unlocking callbacks instead of InteractionManager.runAfterInteractions() which can be paused for as long as any interactive animation is running.

Related issues

#106

Test Plan

n/a

Documentation changes

n/a

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

n/a

Use setImmediate instead of InteractionManager.runAfterInteractions() which can be paused for as long as any interactive animation is running.
@nkshah2 nkshah2 changed the base branch from master to 4.0 September 13, 2023 03:40
@nkshah2
Copy link
Contributor

nkshah2 commented Sep 13, 2023

Hey @melvynhills

The PR looks good, just a heads up I made a tiny change to your branch to make the tests a little less unreliable. We'll get this merged sometime this week

@rishabhpoddar rishabhpoddar merged commit 3726602 into supertokens:4.0 Sep 13, 2023
@rishabhpoddar
Copy link
Contributor

We have also added your profile to the supertokens-core readme :)

@melvynhills
Copy link
Contributor Author

Yeah I didn't take the time to try to run the tests nor patch my local node_modules yet, so I guess it needs some testing before production release?
Thanks guys!

@rishabhpoddar
Copy link
Contributor

Yea, we did run tests on our CICD already. And have released it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants