Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add dateprovider.js bundle #106

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

anku255
Copy link
Contributor

@anku255 anku255 commented Feb 7, 2024

Summary of change

This PR adds the dateprovider.js bundle file allowing DateProvider to be used with script tags as well. After importing the dateprovider.js bundle file, it can be used as

const timeNow = supertokensDateProvider.DateProviderReference.getReferenceOrThrow().dateProvider.now();

Test Plan

Tested locally by creating a web server in the bundle folder, along with an index.html file. Imported the required bundles and confirmed that DateProvider initialized correctly after calling supertokens.init.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • webJsInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Copy link

github-actions bot commented Feb 7, 2024

size-limit report 📦

Path Size
lib/build/index.js 25.95 KB (+0.01% 🔺)
recipe/emailverification/index.js 26.31 KB (+0.01% 🔺)
recipe/emailpassword/index.js 26.04 KB (0%)
recipe/thirdparty/index.js 27.09 KB (+0.01% 🔺)
recipe/thirdpartyemailpassword/index.js 29.03 KB (0%)
recipe/session/index.js 23.19 KB (0%)
recipe/passwordless/index.js 27.36 KB (0%)
recipe/thirdpartypasswordless/index.js 29.73 KB (+0.01% 🔺)
recipe/userroles/index.js 23.45 KB (0%)
recipe/multitenancy/index.js 25.69 KB (0%)

@rishabhpoddar rishabhpoddar merged commit 9cd270e into 0.9 Feb 8, 2024
4 of 5 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/add-date-provider-bundle branch February 8, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants