Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add wrappers around webauthn methods to handle native API calls #124

Open
wants to merge 20 commits into
base: feat/webauthn
Choose a base branch
from

Conversation

deepjyoti30-st
Copy link

@deepjyoti30-st deepjyoti30-st commented Dec 10, 2024

Summary of change

Adds webauthn wrapper methods around the API methods for ease of usage.

Related issues

Test Plan

Tests will be written later on in the auth-react repo

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • webJsInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Copy link

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size
lib/build/index.js 27.23 KB (0%)
recipe/emailverification/index.js 27.65 KB (0%)
recipe/emailpassword/index.js 27.6 KB (0%)
recipe/thirdparty/index.js 28.39 KB (0%)
recipe/session/index.js 24.37 KB (0%)
recipe/passwordless/index.js 28.66 KB (0%)
recipe/userroles/index.js 24.64 KB (0%)
recipe/multitenancy/index.js 26.95 KB (0%)
recipe/multifactorauth/index.js 27.05 KB (0%)
recipe/totp/index.js 26.87 KB (0%)
recipe/oauth2provider/index.js 27.4 KB (0%)

@deepjyoti30-st deepjyoti30-st changed the title Add wrappers around webauthn methods to handle native API calls feat: Add wrappers around webauthn methods to handle native API calls Dec 11, 2024
@deepjyoti30-st deepjyoti30-st marked this pull request as ready for review December 11, 2024 13:47
lib/ts/recipe/webauthn/types.ts Outdated Show resolved Hide resolved
lib/ts/recipe/webauthn/types.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants