SanitizeDefine fix for different cultures. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used en-GB culture info in ToUpper method. Lets say we want to convert "Android" to upper case. Without a cultureinfo, ToUpper method uses local computer's culture info. For example for Turkish Android is convertoed to ANDROİD. This was causing BUILD_ARCH_ANDRO_D scripting defines in player settings.
|
Thanks @hilminamli, that's a good catch!
|
Used String.ToUpperInvariant() to avoid the varying uppercase conversion rules of different cultures. After this changes runned build for 3 platform at same time Android IL2CPP PC IL2CPP MacOS Mono
|
Hey @robinnorth, Just updated the PR to replace all ToUpper methods with String.ToUpperInvariant. Super usefull tool, especially with pre and post build actions. Keep it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used en-GB culture info in ToUpper method.
Lets say we want to convert "Android" to upper case. Without a cultureinfo, ToUpper method uses local computer's culture info. For example for Turkish Android is converted to ANDROİD. This was causing in scripting defines in player settings.
Before Fix:
After Fix: