Added display of immediate operands to disassembly #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug output's disassembly now displays immediate values passed to instructions, when applicable.
weijuwang
commented
Jul 21, 2022
| @@ -4,6 +4,7 @@ | |||
| #include <stdio.h> | |||
| #include <stdint.h> | |||
| #include <stdbool.h> | |||
| #include <string.h> | |||
|
Hello, thank you for the contribution! Can you use |
%hu -> %02X, %hhu -> %04X Since immediates are being displayed in hex, an H is also added to the end of the value.
|
Should be fixed now. |
|
On a somewhat related note: the disassembly could be made more readable if some more spaces were added, e.g. as opposed to I could make a separate PR if needed, since it's not strictly related to immediate operands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #5. I replaced all the placeholders in the disassembly table with either
%hhufor 8-bit immediates or%hufor 16-bit immediates. These are formats thatprintfunderstands. When disassembling an instruction, the code then looks for these substrings in the instruction's assembly representation and, if needed, passes the value of the immediate from memory as an argument toprintfso that it can be displayed.