Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix animations #95

Merged
merged 4 commits into from
Feb 22, 2024
Merged

feat: Fix animations #95

merged 4 commits into from
Feb 22, 2024

Conversation

internetova
Copy link
Collaborator

Changes

Fixed

  • Sticking when closing at the end

Changed

  • Split the animation speed into opening and closing speeds. The closing speed has been reduced.
  • FlexibleBottomSheetRoute has been made public
2024-02-22.09.35.23.mov
2024-02-22.09.36.09.mov

Checklist for self-check

  • Commits and PRs have been filed according to the rules on the project.
  • The author is marked as an assigne and assigned mandatory reviewers.
  • Required labels marked
  • Specified related tasks and/or related PRs.
  • Specified Changes.
  • Attached videos/screenshots demonstrating the fix/feature.
  • All unspecified fields in the PR description deleted.
  • New code covered by tests.

Checklist for reviewers

  • CI passed successfully (with a green check mark).
  • PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

  • System design corresponds to the agreements on structure and architecture on the project.
  • The code is decomposed into necessary and sufficient components.

Functionality:

  • The code solves the problem.
  • Any changes to the user interface are reasonable and look good.

Complexity:

  • The code is clear, easy to read, functions are small, no more than 50 lines.
  • The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

  • Updated or added tests for mandatory components.
  • The tests are correct, helpful, and well designed/developed.

Naming:

  • The naming of variables, methods, classes and other components is understandable.

Comments:

  • The comments are understandable and helpful.

Documentation:

  • All labels are correct
  • Technical documentation updated (after approval, updates last reviewer).

@internetova internetova self-assigned this Feb 22, 2024
@internetova internetova added enhancement New feature or request bug Something isn't working labels Feb 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b126c39) 100.00% compared to head (2959672) 100.00%.

❗ Current head 2959672 differs from pull request most recent head 5037257. Consider uploading reports for the commit 5037257 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          273       273           
=========================================
  Hits           273       273           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxim-sysoev maxim-sysoev merged commit d14308b into main Feb 22, 2024
11 checks passed
@maxim-sysoev maxim-sysoev deleted the fix_animations branch February 22, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request new pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants