Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SNP-926): ScrollController initializations moved form constructor #30

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

DmitrDomrachev
Copy link
Contributor

Changes

ScrollController initialization moved from the _CupertinoSwipeRefreshState constructor.

Issues

Resolve #4

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36fd61b) 100.00% compared to head (244dbbd) 100.00%.

❗ Current head 244dbbd differs from pull request most recent head faf52bd. Consider uploading reports for the commit faf52bd to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          176       176           
=========================================
  Hits           176       176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ekinsdrow ekinsdrow self-requested a review March 21, 2024 10:27
@ekinsdrow ekinsdrow merged commit a5c158f into main Mar 21, 2024
7 checks passed
@ekinsdrow ekinsdrow deleted the SNP-926_scroll_controller_init branch March 21, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove RefreshControlIndicatorBuilder from adaptive constructors
4 participants