Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ahash::HashSet #143

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Use ahash::HashSet #143

merged 1 commit into from
Nov 28, 2024

Conversation

gsserge
Copy link
Contributor

@gsserge gsserge commented Nov 28, 2024 •
edited
Loading

Just a small cleanup:

  • Use HashSet with ahash.
  • I don't think there's need to insert a key in the unique keys set when processing the last key's versions.
  • Fixing clippy lints for Rust 1.83.0.

@gsserge gsserge requested a review from arriqaaq November 28, 2024 14:40
@gsserge gsserge marked this pull request as ready for review November 28, 2024 14:40
@gsserge gsserge merged commit 703332d into main Nov 28, 2024
7 checks passed
@gsserge gsserge deleted the hashset branch November 28, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arriqaaq arriqaaq arriqaaq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsserge @arriqaaq