-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make metal3 helm chart compatible with the Sylva project #39
Conversation
charts/metal3-deploy/0.1.0/charts/ironic/charts/mariadb/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/metal3-deploy/0.1.0/charts/baremetal-operator/templates/configmap-ironic.yaml
Outdated
Show resolved
Hide resolved
charts/metal3-deploy/0.1.0/charts/baremetal-operator/templates/configmap-ironic.yaml
Outdated
Show resolved
Hide resolved
charts/metal3-deploy/0.1.0/charts/baremetal-operator/templates/configmap-ironic.yaml
Outdated
Show resolved
Hide resolved
charts/metal3-deploy/0.1.0/charts/ironic/templates/configmap.yaml
Outdated
Show resolved
Hide resolved
Overall this looks good, but in future IMHO it would be much better to break changes like this into several PRs since it contains several logically unrelated changes - this would be far easier/faster to review. The main issue I see is the DATABASE_HOST change is backwards incompatible and won't work with the default chart configuration - I think that means we either add a conditional for empty |
charts/metal3-deploy/0.1.0/charts/ironic/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
I mentioned it on #38, but just to cover here also. Merging #37 and #38 in |
f52c47a
to
b12c9e1
Compare
#37 and #38 have been merged and this PR has been rebased on top of them in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm - couple of small comments/questions related to the configurable values.
Change suggestions have been addressed. |
This PR introduces changes that enable the
metal3-deploy
helm chart to be successfully deployed within the Sylva project.Changes related to the MariaDB chart:
Commits:
Changes related to the Ironic chart:
Commits:
Changes related to the Baremetal-operator chart:
clusterctl.cluster.x-k8s.io
label to all CRDs in order to ensure that they can be pivoted when doingclusterctl move
Commits: