Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate NM config #5

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Conversation

atanasdinov
Copy link
Collaborator

  • Initializes the nmc Rust crate
    • nmc will be a CLI exposing generate and apply subcommands
    • generate will generate the network configuration for a set of different hosts defined as YAML files in a user provided directory
    • apply will identify the host which the CLI is running on and apply the network configuration (replacing the existing Go implementation)
  • Adds initial generate implementation
  • Follow ups will include further validation, more tests, CI changes, documentation

Signed-off-by: Atanas Dinov <[email protected]>
Signed-off-by: Atanas Dinov <[email protected]>
Signed-off-by: Atanas Dinov <[email protected]>
Signed-off-by: Atanas Dinov <[email protected]>
@atanasdinov atanasdinov marked this pull request as ready for review November 6, 2023 13:08
Copy link

@diconico07 diconico07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, LGTM

src/generate_conf.rs Outdated Show resolved Hide resolved
src/generate_conf.rs Outdated Show resolved Hide resolved
src/generate_conf.rs Outdated Show resolved Hide resolved
src/generate_conf.rs Outdated Show resolved Hide resolved
src/generate_conf.rs Outdated Show resolved Hide resolved
src/generate_conf.rs Outdated Show resolved Hide resolved
src/generate_conf.rs Outdated Show resolved Hide resolved
@atanasdinov atanasdinov merged commit 1447c56 into suse-edge:main Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants