Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SmoothTrend #37

Merged
merged 11 commits into from
May 23, 2020

Conversation

tanmay-1srivastava
Copy link
Contributor

#27

Copy link
Collaborator

@apoorvagnihotri apoorvagnihotri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with the current edits. Could you please address them in your next commits?

Comment on lines 336 to 344
<<<<<<< HEAD
return map_
=======
return map_
>>>>>>> 160196764e2db9f7167fd1b1acdbfce29ed6218f
=======
return map_
>>>>>>> 160196764e2db9f7167fd1b1acdbfce29ed6218f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might have an issue here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should just be

return map_

Copy link
Collaborator

@apoorvagnihotri apoorvagnihotri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some changes.

@tanmay-1srivastava
Copy link
Contributor Author

tanmay-1srivastava commented May 22, 2020 via email

@apoorvagnihotri apoorvagnihotri merged commit ef99aef into sustainability-lab:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants