-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SmoothTrend #37
Updated SmoothTrend #37
Conversation
…nto sustainability-lab-master vayu/smoothTrend.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some issues with the current edits. Could you please address them in your next commits?
vayu/interactiveChoroplethPlot.py
Outdated
<<<<<<< HEAD | ||
return map_ | ||
======= | ||
return map_ | ||
>>>>>>> 160196764e2db9f7167fd1b1acdbfce29ed6218f | ||
======= | ||
return map_ | ||
>>>>>>> 160196764e2db9f7167fd1b1acdbfce29ed6218f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might have an issue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should just be
return map_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some changes.
Hey Apoorv,
I have made the changes. Please check.
Thanks
…On Fri, May 22, 2020 at 5:18 PM Apoorv Agnihotri ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In vayu/interactiveChoroplethPlot.py
<#37 (comment)>
:
> +<<<<<<< HEAD
+<<<<<<< HEAD
+ return map_
+=======
+ return map_
+>>>>>>> 1601967
+=======
+ return map_
+>>>>>>> 1601967
It should just be
return map_
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGEL4QPTHAVMCF7MFFUZ2VDRSZRCNANCNFSM4NHVCXCQ>
.
--
Thank You
Tanmay Srivastav
Bharti Vidyapeeth's College of Engineering
Website: bit.ly/tanmaySrivastava
LinkedIn: https://www.linkedin.com/in/tanmay-srivastava-335775170/
|
#27