Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relabelings for ServiceMonitor #57

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

YaSuenag
Copy link
Contributor

I'd like to configure relabelings in ServiceMonitor of Kepler.

Signed-off-by: Yasumasa Suenaga <[email protected]>
@yellowhat
Copy link
Contributor

Could you bump the chart version?

@YaSuenag
Copy link
Contributor Author

I've proposed other PR #56 . I'd like to bump the chart version when both PRs are merged.

If this PR is merged at first, I'll do that in #56.

@YaSuenag
Copy link
Contributor Author

@yellowhat Thank you for approving this PR!

BTW I found #55 . Should we merge #55 rather than creating new PR to bump?

@yellowhat
Copy link
Contributor

Someone has to approve it otherwise I cannot merge it

@YaSuenag
Copy link
Contributor Author

Ok, so I will bump up the version in #56 when this PR is merged.

@yellowhat
Copy link
Contributor

Are you able to contact any other maintainer?
My PR has been there for weeks.
Thanks

@YaSuenag
Copy link
Contributor Author

Are you able to contact any other maintainer?

No, but I can request the review in Kepler community meeting, however it would be better if you do 😉

Anyway I will ask if I can attend next meeting.

@rootfs rootfs merged commit 42bba8b into sustainable-computing-io:main Jan 22, 2024
3 checks passed
@YaSuenag YaSuenag deleted the pr/add-relabelings branch January 22, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants