-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: remove /sys/kernel/debug mount #198
Feat: remove /sys/kernel/debug mount #198
Conversation
@BGrasnick I agree, but the lack of automated validation against OpenShift is hurting us here. I am happy to merge this patch as soon as we make a |
Yes I totally understand that! Unfortunately, my knowledge about the kepler internals regarding eBPF, bcc and libbpf is not that deep (yet) but maybe somebody who knows more about it can enlighten us and tell us if this is still needed :) When testing by running the operator locally and installing kepler + the Grafana dashboard without the /sys/kernel/debug mount I could still see metrics in Grafana with both latest and latest-libbpf images if I recall correctly so it should work from my understanding. |
Lets wait for sustainable-computing-io/kepler#926 to be merged before merging this PR. I suspect looking at libbpf that we may need it |
Since /sys is already mounted, we need not mount /sys/kernel/* Signed-off-by: Bastien Grasnick <[email protected]>
a0aeadb
to
d10befa
Compare
Since sustainable-computing-io/kepler#926 is merged now, do you think we can move forward with this? |
closing this since #322 adds this change. |
perfect, thank you @sthaha |
Feat: remove /sys/kernel/debug mount
fixes #177
Signed-off-by: Bastien Grasnick [email protected]